Definedness: Ret and Break are eager uses AST-65#205
Merged
Conversation
nomeata
changed the base branch from
master
to
joachim/return-before-define-tests
nomeata
force-pushed
the
joachim/return-before-define
branch
from
c2fdf55 to
6058dc3
Compare
nomeata
changed the base branch from
joachim/return-before-define-tests
to
master
nomeata
force-pushed
the
joachim/return-before-define
branch
from
6058dc3 to
512b0c8
Compare
Contributor
Author
|
You did not click the magic button to approve :-) |
ggreif
approved these changes
Mar 3, 2019
Contributor
ggreif
left a comment
ggreif
left a comment
There was a problem hiding this comment.
Makes total sense. Let's see if the typo suggestions invalidate my approval when followed.
Contributor
|
Just a question. When a (first) use happens in an eager context, after a |
Co-Authored-By: nomeata <mail@joachim-breitner.de>
Contributor
Author
Yes; after all the |
dfinity-bot
added a commit
that referenced
this pull request
Jan 12, 2021
## Changelog for motoko-base: Branch: next-moc Commits: [caffeinelabs/motoko-base@5e010560...65855b98](caffeinelabs/motoko-base@5e01056...65855b9) * [`4be1b41e`](caffeinelabs/motoko-base@4be1b41) upgrade matchers, motoko release and use do blocks in tests ([dfinity-lab/motoko-base#203](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/203)) * [`dc3c5286`](caffeinelabs/motoko-base@dc3c528) fix doc examples to be executable ([dfinity-lab/motoko-base#205](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/205))
mergify bot
pushed a commit
that referenced
this pull request
Jan 12, 2021
## Changelog for motoko-base: Branch: next-moc Commits: [caffeinelabs/motoko-base@5e010560...65855b98](caffeinelabs/motoko-base@5e01056...65855b9) * [`4be1b41e`](caffeinelabs/motoko-base@4be1b41) upgrade matchers, motoko release and use do blocks in tests ([dfinity-lab/motoko-base#203](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/203)) * [`dc3c5286`](caffeinelabs/motoko-base@dc3c528) fix doc examples to be executable ([dfinity-lab/motoko-base#205](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/motoko-base/issues/205))
dfinity-bot
added a commit
that referenced
this pull request
May 7, 2021
## Changelog for candid: Branch: master Commits: [dfinity/candid@043c81bb...a555d777](dfinity/candid@043c81b...a555d77) * [`a555d777`](dfinity/candid@a555d77) candid ui canister ([dfinity/candid#205](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/205))
mergify bot
pushed a commit
that referenced
this pull request
May 7, 2021
## Changelog for candid: Branch: master Commits: [dfinity/candid@043c81bb...a555d777](dfinity/candid@043c81b...a555d77) * [`a555d777`](dfinity/candid@a555d77) candid ui canister ([dfinity/candid#205](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/205))
dfinity-bot
added a commit
that referenced
this pull request
Jun 24, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@f092a2d5...c2cedde6](dfinity/ic-hs@f092a2d...c2cedde) * [`f3acf563`](dfinity/ic-hs@f3acf56) attach cycles to canister creation in canister history tests ([dfinity/ic-hs#203](https://github.com/dfinity/ic-hs/issues/203)) * [`f5c6e6ec`](dfinity/ic-hs@f5c6e6e) restart ic-ref in tests ([dfinity/ic-hs#204](https://github.com/dfinity/ic-hs/issues/204)) * [`c2cedde6`](dfinity/ic-hs@c2cedde) update http_request fee calculation ([dfinity/ic-hs#205](https://github.com/dfinity/ic-hs/issues/205))
mergify bot
pushed a commit
that referenced
this pull request
Jun 24, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@f092a2d5...c2cedde6](dfinity/ic-hs@f092a2d...c2cedde) * [`f3acf563`](dfinity/ic-hs@f3acf56) attach cycles to canister creation in canister history tests ([dfinity/ic-hs#203](https://github.com/dfinity/ic-hs/issues/203)) * [`f5c6e6ec`](dfinity/ic-hs@f5c6e6e) restart ic-ref in tests ([dfinity/ic-hs#204](https://github.com/dfinity/ic-hs/issues/204)) * [`c2cedde6`](dfinity/ic-hs@c2cedde) update http_request fee calculation ([dfinity/ic-hs#205](https://github.com/dfinity/ic-hs/issues/205))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.